Make ActivationRegistrationManager.RegisterForFileTypeActivation() case-insensitive for paths#8
Draft
Make ActivationRegistrationManager.RegisterForFileTypeActivation() case-insensitive for paths#8
Conversation
Co-authored-by: MuyuanMS <[email protected]>
Co-authored-by: MuyuanMS <[email protected]>
Copilot
AI
changed the title
[WIP] ActivationRegistrationManager.RegisterForFileTypeActivation() - path parameter is case sensitive
Make ActivationRegistrationManager.RegisterForFileTypeActivation() case-insensitive for paths
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an issue where
RegisterForFileTypeActivation()would create duplicate registry entries if the same path was specified with different casing (e.g., "app.exe" vs "App.exe"). This caused problems with single instancing when applications were registered with file paths whose case differed from the actual file system.Solution
The issue was identified in the
ComputeAppId()function which creates a hash from the provided executable path. This hash is used to generate registry entries, but the function wasn't normalizing the case of file paths before hashing.Changes made:
ComputeAppId()to detect if the input is a file pathFileTypeActivation_CaseInsensitivityto verify paths differing only by case produce the same AppIdTesting
Added a specific test case that:
ComputeAppId()on both pathsThis ensures that when applications register with file paths that differ only in case, they will create the same registry entry, maintaining proper single instancing behavior.
Fixes #7.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.